Make sha256 required parameter for SigV4 constructor #1335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
changed the title
kuhe
approved these changes
Jul 12, 2024
JordonPhillips
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes: aws/aws-sdk-js-v3#3590
Description of changes:
The SignatureV4 implementation was originally added in aws/aws-sdk-js-v3#36 seven years ago, where
sha256was not optional. It was incorrectly made optional in aws/aws-sdk-js-v3#58.This issue was not noticed during development of AWS SDK for JavaScript packages, since we always passed
sha256as linked in aws/aws-sdk-js-v3#3590 (comment). However, it was an issue for some customers who called it directly. As described in the issue, those customers providedsha256implementation as a workaround.This PR makes
sha256a required parameter, as required by the implementation.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.