Skip to content

Initialize removeSignalEventListener as an empty function #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 26, 2024
Merged

Initialize removeSignalEventListener as an empty function #1351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f34192d
Verify that removeSignalEventListener is a function before calling
trivikr Jul 26, 2024
976cf07
chore: yarn changeset
trivikr Jul 26, 2024
28d0ce8
Initialize removeSignalEventListener as an empty function
trivikr Jul 26, 2024
eb2991b
chore: yarn changeset
trivikr Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/unlucky-glasses-nail.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@smithy/fetch-http-handler": patch
---

Initialize removeSignalEventListener as an empty function
2 changes: 1 addition & 1 deletion packages/fetch-http-handler/src/fetch-http-handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ export class FetchHttpHandler implements HttpHandler<FetchHttpHandlerConfig> {
requestOptions.keepalive = keepAlive;
}

let removeSignalEventListener = null as null | (() => void);
let removeSignalEventListener = () => {};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let removeSignalEventListener = () => {};
// react-native promises cannot accept non-function as a then/catch/finally step.
let removeSignalEventListener = () => {};

Copy link
Contributor Author

@trivikr trivikr Jul 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the comment is necessary, as this fix changes removeSignalEventListener type to a function?


const fetchRequest = new Request(url, requestOptions);
const raceOfPromises = [
Expand Down
Loading