fix: prevent infinite recursion with NoUndefined and RecursiveRequired re: DocumentType

[gschwart]

Issue #, if available:

Description of changes:

When trying to use AssertiveClient or UncheckedClient for a request that contains a field of type DocumentType results in the following TypeScript error:

 error TS2589: Type instantiation is excessively deep and possibly infinite.

Cause

Inside the AssertiveClient type definition, the NoUndefined type:

export type NoUndefined<T> = T extends Function ? T : [T] extends [object] ? {
    [key in keyof T]: NoUndefined<T[key]>;
} : Exclude<T, undefined>;

recursively iterates excluding undefined. The issue stems from the type DocumentType since it is self-referential which results in an infinite loop.

export type DocumentType = null | boolean | number | string | DocumentType[] | {
    [prop: string]: DocumentType;
};

Fix

Update the NoUndefined and RecursiveRequired types to ignore DocumentType fields:

export type NoUndefined<T> = T extends Function
  ? T 
  : T extends DocumentType
  ? T 
  : [T] extends [object]
    ? {
        [key in keyof T]: NoUndefined<T[key]>;
      }
    : Exclude<T, undefined>;

---

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.