fix(util-waiter): fix waiter validation #1491
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws/aws-sdk-js-v3#6767
Description of changes:
The waitUntilObjectExists function was incorrectly throwing an error:
Error: WaiterConfiguration.minDelay must be greater than 0
When minDelay was set to 0.5.
Changes Made:
Updated validateWaiterOptions to only throw an error if minDelay, maxDelay, or maxWaitTime are less than or equal to 0 instead of < 1.
Added a test case to verify that small values like 0.01 do not throw an error.
This ensures that fractional values (e.g., 0.5, 0.01) work correctly while keeping 0 invalid.
Testing
for util-waiter:
✓ src/waiter.spec.ts (5)
✓ src/utils/validate.spec.ts (7)
✓ src/poller.spec.ts (5)
✓ src/index.spec.ts (1)
✓ src/createWaiter.spec.ts (3)
Test Files 5 passed (5)
Tests 21 passed (21)
Start at 12:01:40
Duration 223ms (transform 105ms, setup 0ms, collect 212ms, tests 15ms, environment 0ms, prepare 227ms)
If one or more of the packages in the
/packages
directory has been modified, be sureyarn changeset add
has been run and its output hasbeen committed and included in this pull request. See CONTRIBUTING.md.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.