feat(util-stream): buffering of stream chunks #1523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
force-pushed
the
feat/buffered-stream
branch
3 times, most recently
from
77dc7a5 to
2e4eca4
Compare
kuhe
changed the title
|
this PR will be used to address aws/aws-sdk-js-v3#6859 |
kuhe
force-pushed
the
feat/buffered-stream
branch
from
2e4eca4 to
6ce0a5d
Compare
siddsriv
reviewed
Feb 13, 2025
| this.byteLength += byteArray.byteLength; | ||
| } | ||
|
|
||
| public flush() { |
There was a problem hiding this comment.
will flush() always create a new aggregate buffer, even if there's only one chunk?
There was a problem hiding this comment.
updated to return single bytearray without copy
siddsriv
approved these changes
Feb 13, 2025
kuhe
force-pushed
the
feat/buffered-stream
branch
from
6ce0a5d to
d52a338
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
createBufferedReadablefn to util-stream to wrap Readable and ReadableStream, buffering chunks to a configurable minimum byte length.