update runtime config customization to be fully overridable #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, some default runtime config values are hard-coded into
templates. This change makes each one of the properties(e.g. requestHandler)
to be overridable by customizations from SDK side. If no customization
exists, the generator can still generate SDK with proper dependencies.
This change is added to support the customization of using WebSocket
requestHandler.
This change also brings in the capability that customization applied
later can override the runtime config values added in earlier
customization. This is necessary sometimes. For example, if customization
A adds runtime config: {x: X, y: Y}. x and y are deeply coupled that
they need to be in the same customization. If there's a single client
needs runtime config {x: X, y: Y-update}, we should be able to make
a new customization overriding the original customization.
AllanZhengYP
force-pushed
the
runtime-config-override
branch
from
8787fa1 to
481c371
Compare
kstich
requested changes
Mar 31, 2020
...-codegen/src/main/java/software/amazon/smithy/typescript/codegen/RuntimeConfigGenerator.java
Outdated
Show resolved
Hide resolved
...-codegen/src/main/java/software/amazon/smithy/typescript/codegen/RuntimeConfigGenerator.java
Outdated
Show resolved
Hide resolved
...c/main/java/software/amazon/smithy/typescript/codegen/integration/TypeScriptIntegration.java
Show resolved
Hide resolved
...egen/src/test/java/software/amazon/smithy/typescript/codegen/RuntimeConfigGeneratorTest.java
Show resolved
Hide resolved
AllanZhengYP
force-pushed
the
runtime-config-override
branch
from
1443d9d to
b8dbafd
Compare
kstich
approved these changes
Apr 3, 2020
srchase
pushed a commit
to srchase/smithy-typescript
that referenced
this pull request
Mar 17, 2023
…ang#153) * update runtime config customization to be fully overridable Previously, some default runtime config values are hard-coded into templates. This change makes each one of the properties(e.g. requestHandler) to be overridable by customizations from SDK side. If no customization exists, the generator can still generate SDK with proper dependencies. This change is added to support the customization of using WebSocket requestHandler. This change also brings in the capability that customization applied later can override the runtime config values added in earlier customization. This is necessary sometimes. For example, if customization A adds runtime config: {x: X, y: Y}. x and y are deeply coupled that they need to be in the same customization. If there's a single client needs runtime config {x: X, y: Y-update}, we should be able to make a new customization overriding the original customization. * Add ordering to customizations; runtimeConfig needs writing a whole line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, some default runtime config values are hard-coded into
templates. This change makes each one of the properties(e.g. requestHandler)
to be overridable by customizations from SDK side. If no customization
exists, the generator can still generate SDK with proper dependencies.
This change is added to support the customization of using WebSocket
requestHandler.
This change also brings in the capability that customization applied
later can override the runtime config values added in earlier
customization. This is necessary sometimes. For example, if customization
A adds runtime config: {x: X, y: Y}. x and y are deeply coupled that
they need to be in the same customization. If there's a single client
needs runtime config {x: X, y: Y-update}, we should be able to make
a new customization overriding the original customization.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.