Skip to content

chore(smithy-client): build-fix, hide submodule export from api-extractor #1596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented May 15, 2025

This change hides core/serde from api-extractor during the doc build process because it does not understand how to import it. It is ok to hide this export because it contains internal interfaces used in serde-functions.

This does not change the runtime behavior of any package or the actual type interface during regular build and publish steps.

Tested with:

npx turbo run extract:docs -F=@smithy/smithy-client

@kuhe kuhe requested a review from a team as a code owner May 15, 2025 01:03
@kuhe kuhe force-pushed the fix/api-extractor branch from e71bfce to b2358df Compare May 15, 2025 01:07
@kuhe
Copy link
Contributor Author

kuhe commented May 15, 2025

Related:

microsoft/rushstack#2142 - "declare module" not supported

microsoft/rushstack#3274 - multiple entry points feature request

@kuhe kuhe merged commit f214d42 into smithy-lang:main May 15, 2025
10 checks passed
@kuhe kuhe deleted the fix/api-extractor branch May 15, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants