Skip to content

add default body value before collecting body stream #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2020

Conversation

AllanZhengYP
Copy link
Contributor

@AllanZhengYP AllanZhengYP commented May 1, 2020

Description of changes:
This changle makes parseBody() function handles empty body. It is useful when testing or request hendler fakes response.

Related: aws/aws-sdk-js-v3#1131

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@kstich kstich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine from Java perspective.

@trivikr trivikr merged commit dc233a9 into smithy-lang:master May 1, 2020
srchase pushed a commit to srchase/smithy-typescript that referenced this pull request Mar 17, 2023
srchase pushed a commit that referenced this pull request Mar 23, 2023
* repoint to @aws-crypto namespace

* add external dependency map for crypto packages
srchase pushed a commit that referenced this pull request Jun 16, 2023
* repoint to @aws-crypto namespace

* add external dependency map for crypto packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants