Update protocol test request body comparison #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the request body comparison generation for protocol tests to safely handle having multiple bodyMediaType settings in the same suite of protocol tests. It also updates the methodology for comparing blob bodies to not be a special case in the generator, as they can have alternate media types.
kstich
requested review from
JordonPhillips
and removed request for
mtdowling
JordonPhillips
approved these changes
Feb 11, 2021
kstich
requested review from
AllanZhengYP and
alexforsyth
and removed request for
AllanZhengYP
|
@kstich what are the generated changes? |
srchase
pushed a commit
to srchase/smithy-typescript
that referenced
this pull request
Mar 17, 2023
This commit updates the request body comparison generation for protocol tests to safely handle having multiple bodyMediaType settings in the same suite of protocol tests. It also updates the methodology for comparing blob bodies to not be a special case in the generator, as they can have alternate media types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the request body comparison generation for
protocol tests to safely handle having multiple
bodyMediaTypesettings in the same suite of protocol tests. It also updates the
methodology for comparing blob bodies to not be a special case in
the generator, as they can have alternate media types.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.