Skip to content

Do not check for labels in empty input while writing hostPrefix #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Feb 23, 2021

Issue #, if available:
Fixes CI failures in aws-sdk-js-v3 which started with https://github.com/aws/aws-sdk-js-v3/actions/runs/590870041

Description of changes:
Do not check for labels in empty input while writing hostPrefix.

Verified that gradle build is successful in aws-sdk-js-v3 after the change from this PR is published to local maven.

$ pwd
/home/trivikr/workspace/smithy-typescript

$ ./gradlew clean publishToMavenLoca
...
...
BUILD SUCCESSFUL in 3s
12 actionable tasks: 11 executed, 1 up-to-date
$ pwd
/home/trivikr/workspace/aws-sdk-js-v3/codegen

$ ./gradlew clean smithy-aws-typescript-codegen:build protocol-test-codegen:build -Plog-tests
...
...
BUILD SUCCESSFUL in 15s
13 actionable tasks: 13 executed

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr merged commit 8ea5676 into smithy-lang:main Feb 23, 2021
@trivikr trivikr deleted the hostPrefix-op-getInput-check branch February 23, 2021 01:59
srchase pushed a commit to srchase/smithy-typescript that referenced this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants