Add ssdk typescript libraries #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the typescript libraries needed to support the SSDK as well as the library that provides apigateway support.
adamthom-amzn
approved these changes
Apr 9, 2021
| if (i === this.pathSegments.length - 1) { | ||
| // greedy label at the end of pathSegments swallows the remaining path segments | ||
| requestPathIdx = requestPathSegments.length; | ||
| break path_loop; |
There was a problem hiding this comment.
Ispath_loop here and line 76 necessary?
There was a problem hiding this comment.
Nah, it's a vestige of when this code was even harder to follow (hard to believe, I know). I kept it in case it made the flow of the break more understandable since there's a lot of nesting, not because the break was ambiguous.
This updates the node dependencies for the ssdk libs to node 14, which is the most recent version supported by Lambda.
JordonPhillips
force-pushed
the
ssdk-ts-libs
branch
from
ab0ffbe to
800686e
Compare
AllanZhengYP
approved these changes
Apr 13, 2021
srchase
pushed a commit
that referenced
this pull request
Mar 23, 2023
srchase
pushed a commit
that referenced
this pull request
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the typescript libraries needed to support the SSDK as well as the library that provides apigateway support.
There's two libraries here:
smithy-typescript/server-common- Defines common interfaces used in generating the ssdk.smithy-typescript/server-apigateway- Provides helpers to convert apigateway events toHttpRequests andHttpResponses to apigateway response format.Out of scope for this PR but still needs to be done:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.