Split server codegen out into a separate plugin #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamthom-amzn
suggested changes
Apr 19, 2021
...pescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/CodegenVisitor.java
Outdated
Show resolved
Hide resolved
Merged
JordonPhillips
force-pushed
the
split-ssdk
branch
from
6cfc06e to
889daeb
Compare
adamthom-amzn
approved these changes
Apr 27, 2021
...ript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/TypeScriptSettings.java
Show resolved
Hide resolved
JordonPhillips
force-pushed
the
split-ssdk
branch
from
2585e42 to
77138a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits up the server code generation to be gated behind a separate plugin. This lets us generate separate packages for each while still being able to generate both a client and ssdk in a single projection.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.