Fix deserialization of paths and query params for servers #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gosar
approved these changes
Jun 25, 2021
JordonPhillips
approved these changes
Jun 28, 2021
...java/software/amazon/smithy/typescript/codegen/integration/HttpBindingProtocolGenerator.java
Outdated
Show resolved
Hide resolved
This decodes potentially-encoded values as early as possible within the deserialization process so that no downstream deserializer needs to reckon with encoding.
adamthom-amzn
force-pushed
the
fix-decode
branch
from
03ec574 to
cfb1eca
Compare
srchase
pushed a commit
that referenced
this pull request
Mar 23, 2023
* chore: add http request type guard for middlewares header default middleware expect continue middleare * chore: add http request type guard for apply body checksum middlewares * chore: only build and test demo smithy client * feat: add isInstance to httpResponse * chore: update rds data model * chore: update to ts3.7; update rds model#3 * chore: update tsconfig to genenerte types only once * chore: update gitignore * chore: parse body with streamCollector * chore: add error deserialization * chore: stub Field union * fix: fix middleware-header-default test * fix: fix retry-middleware unit test
srchase
pushed a commit
that referenced
this pull request
Apr 26, 2023
* chore: add http request type guard for middlewares header default middleware expect continue middleare * chore: add http request type guard for apply body checksum middlewares * chore: only build and test demo smithy client * feat: add isInstance to httpResponse * chore: update rds data model * chore: update to ts3.7; update rds model#3 * chore: update tsconfig to genenerte types only once * chore: update gitignore * chore: parse body with streamCollector * chore: add error deserialization * chore: stub Field union * fix: fix middleware-header-default test * fix: fix retry-middleware unit test
srchase
pushed a commit
that referenced
this pull request
Jun 16, 2023
* chore: add http request type guard for middlewares header default middleware expect continue middleare * chore: add http request type guard for apply body checksum middlewares * chore: only build and test demo smithy client * feat: add isInstance to httpResponse * chore: update rds data model * chore: update to ts3.7; update rds model#3 * chore: update tsconfig to genenerte types only once * chore: update gitignore * chore: parse body with streamCollector * chore: add error deserialization * chore: stub Field union * fix: fix middleware-header-default test * fix: fix retry-middleware unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This decodes potentially-encoded values as early as possible within the
deserialization process so that no downstream deserializer needs to reckon with
encoding.
It also enforces that we don't accept multiple values for query strings that are modeled as single values.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.