Fix query matching against list query values #450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing code doesn't account for the fact that all query parameter values can be multi-valued, even when there's only one value in the input URL. Also, a query string literal can be satisfied by any of the values in the input URL, whereas the existing code would insist that there exist no other value for the key in the literal.
JordonPhillips
approved these changes
Oct 11, 2021
trivikr
approved these changes
Oct 13, 2021
srchase
pushed a commit
that referenced
this pull request
Mar 23, 2023
srchase
pushed a commit
that referenced
this pull request
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The existing code doesn't account for the fact that all query parameter values
can be multi-valued, even when there's only one value in the input URL. Also,
a query string literal can be satisfied by any of the values in the input URL,
whereas the existing code would insist that there exist no other value for the
key in the literal.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.