Skip to content

Revert support delegation of determining errors for an operation #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Jan 14, 2022

Issue #, if available:
Internal JS-3027

This code change surfaced a bug in our error deserializer, where the error message is modeled to be in key message but the actual message is response payload with key Message.

Description of changes:
This reverts commit a56d352 added in #489.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner January 14, 2022 21:49
@trivikr trivikr marked this pull request as draft January 14, 2022 21:52
@trivikr trivikr marked this pull request as ready for review January 14, 2022 22:08
@trivikr trivikr merged commit 41de58c into smithy-lang:main Jan 14, 2022
@trivikr trivikr deleted the revert-aws-query-error-trait branch January 14, 2022 23:31
srchase pushed a commit to srchase/smithy-typescript that referenced this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants