fix non modular client generation #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllanZhengYP
force-pushed
the
zheallan-dev
branch
2 times, most recently
from
05fbff6 to
557293f
Compare
Also update operation deserializer to only parse body when for non streaming operation deserializer. This way we won't wait and collect the streaming response
AllanZhengYP
force-pushed
the
zheallan-dev
branch
6 times, most recently
from
46ef292 to
dfb3c94
Compare
When preparing reponse body for command deserializers or error deserializers, we don't always collect response body binaries in structured JS object. If the command ouput or error has a streaming trait, we need to keep the response body intact and return users the raw response stream.
kstich
approved these changes
Dec 12, 2019
srchase
pushed a commit
that referenced
this pull request
Mar 23, 2023
* implement ec2-marshaller * enable xml parser to handle resultWrapper and requestId in body; impliment a query-unmarshaller to unmarshal query including ec2 * sort the keys in structure shape * add httpResponse to ResponseMetadata * move query-marshaller & query-unmarshaller to protocol-query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are included:
populate parseBody() for non streaming command reponse and errors:
When preparing reponse body for command deserializers or error
deserializers, we don't always collect response body binaries
in structured JS object. If the command ouput or error has a
streaming trait, we need to keep the response body intact and
return users the raw response stream.
Update non-modular client generator to reflect the newest client interface
Fix typing issues in commands
This PR generates a buildable full-blood RDS-data client: aws/aws-sdk-js-v3#496
/cc @kstich
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.