Skip to content

import SmithyException, isa and DocumentType from smithy-client instead of lib/smithy #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 12, 2019

Conversation

srchase
Copy link
Contributor

@srchase srchase commented Dec 10, 2019

Import SmithyException, isa and DocumentType from smithy-client package.

Remove lib/smithy static content

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@srchase
Copy link
Contributor Author

srchase commented Dec 10, 2019

smithy-core package added in aws/aws-sdk-js-v3#546

@srchase
Copy link
Contributor Author

srchase commented Dec 10, 2019

This code could also get added to @aws-sdk/smithy-client. I don't think smithy-core would be used independently of smithy-client, so may make sense to bundle them into one package.

@srchase
Copy link
Contributor Author

srchase commented Dec 11, 2019

Approved in aws/aws-sdk-js-v3#546 as "smithy-core"

@srchase srchase changed the title use smithy-core package as aws dependency import SmithyException, isa and DocumentType from smithy-client instead of lib/smithy Dec 12, 2019
@kstich kstich merged commit afd715a into smithy-lang:master Dec 12, 2019
@srchase srchase deleted the smithy-core branch December 17, 2019 22:22
srchase pushed a commit that referenced this pull request Mar 23, 2023
* Adds XmlBodyBuilder for serializing XML bodies.

* Adds REST Marhsaller/Unmarshaller.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants