Fix the uniqueItems implementation to accommodate non-primitive values #511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamthom-amzn
force-pushed
the
fix-uniqueness
branch
from
39c0274 to
313fb3d
Compare
adamthom-amzn
force-pushed
the
fix-uniqueness
branch
2 times, most recently
from
c75d45f to
c568610
Compare
gosar
reviewed
Feb 17, 2022
| }); | ||
|
|
||
| // This is relatively slow and may be flaky if the input size is tuned to let it run reasonably fast | ||
| it.skip("is faster than the naive implementation", () => { |
| import * as util from "util"; | ||
|
|
||
| /** | ||
| * A shortcut for document-like objects or Smithy structures. |
There was a problem hiding this comment.
Broader than that? in that it includes primitives like number
JavaScript Sets do not work in the same fashion as HashSets do in Java, in that object equivalence is determined by reference, not by value. In order to work around this, this commit adds a duplicate finder that works on the same principals as a value-based hashtable: it creates a hash of the object's value to bucket objects and then uses deep equality to determine if a hash collision is actually a duplicate value.
adamthom-amzn
force-pushed
the
fix-uniqueness
branch
from
c568610 to
317d8d9
Compare
gosar
approved these changes
Feb 18, 2022
trivikr
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
JavaScript Sets do not work in the same fashion as HashSets do in Java, in that
object equivalence is determined by reference, not by value. In order to work
around this, this commit adds a duplicate finder that works on the same
principals as a value-based hashtable: it creates a hash of the object's value
to bucket objects and then uses deep equality to determine if a hash collision
is actually a duplicate value.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.