Updates for HTTP serde correctness and safety #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit includes updates to Http ProtocolGenerator components for correctness and safety. 1. It fixes generation issues for the @httpPrefixHeaders trait in the HttpBindingProtocolGenerator. 2. It updates SerdeContext to use an import alias for safety. 3. It only generates a local parsedOutput if it will be consumed. 4. It adds the Error type to the list of Typescript reserved words.
mtdowling
reviewed
Dec 10, 2019
...java/software/amazon/smithy/typescript/codegen/integration/HttpBindingProtocolGenerator.java
Outdated
Show resolved
Hide resolved
mtdowling
approved these changes
Dec 11, 2019
kstich
force-pushed
the
protocol_fixes_2
branch
from
ac98bc3 to
b7cf53f
Compare
mtdowling
approved these changes
Dec 12, 2019
srchase
pushed a commit
that referenced
this pull request
Mar 23, 2023
* Add README files to credential provider packages * Be stricter in documentation about which date strings are accepted
srchase
pushed a commit
that referenced
this pull request
Jun 16, 2023
* Add README files to credential provider packages * Be stricter in documentation about which date strings are accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit includes updates to Http ProtocolGenerator components for
correctness and safety.
the HttpBindingProtocolGenerator.
Use Model instead of deprecated ShapeIndex. This commit will require using the latest version of Smithy published locally.
Use better name for document body shape serde gen
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.