Skip to content

Refactor decorateSymbolProvider to match SmithyIntegration #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2022
Merged

Refactor decorateSymbolProvider to match SmithyIntegration #544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...cript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/CodegenVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ class CodegenVisitor extends ShapeVisitor.Default<Void> {
// Decorate the symbol provider using integrations.
SymbolProvider resolvedProvider = artifactType.createSymbolProvider(model, settings);
for (TypeScriptIntegration integration : integrations) {
resolvedProvider = integration.decorateSymbolProvider(settings, model, resolvedProvider);
resolvedProvider = integration.decorateSymbolProvider(model, settings, resolvedProvider);
}
symbolProvider = SymbolProvider.cache(resolvedProvider);

Expand Down
2 changes: 1 addition & 1 deletion ...a/software/amazon/smithy/typescript/codegen/integration/AddBaseServiceExceptionClass.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ public void writeAdditionalExports(
*/
@Override
public SymbolProvider decorateSymbolProvider(
TypeScriptSettings settings,
Model model,
TypeScriptSettings settings,
SymbolProvider symbolProvider
) {
return shape -> {
Expand Down
4 changes: 2 additions & 2 deletions ...ain/java/software/amazon/smithy/typescript/codegen/integration/TypeScriptIntegration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,14 +75,14 @@ default Model preprocessModel(PluginContext context, TypeScriptSettings settings
* <p>This can be used to customize the names of shapes, the package
* that code is generated into, add dependencies, add imports, etc.
*
* @param settings Setting used to generate.
* @param model Model being generated.
* @param settings Setting used to generate.
* @param symbolProvider The original {@code SymbolProvider}.
* @return The decorated {@code SymbolProvider}.
*/
default SymbolProvider decorateSymbolProvider(
TypeScriptSettings settings,
Model model,
TypeScriptSettings settings,
SymbolProvider symbolProvider
) {
return symbolProvider;
Expand Down
2 changes: 1 addition & 1 deletion ...n/src/test/java/software/amazon/smithy/typescript/codegen/SymbolDecoratorIntegration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
public final class SymbolDecoratorIntegration implements TypeScriptIntegration {
@Override
public SymbolProvider decorateSymbolProvider(
TypeScriptSettings settings,
Model model,
TypeScriptSettings settings,
SymbolProvider symbolProvider
) {
String name = settings.getPluginSettings().getStringMemberOrDefault("__customServiceName", null);
Expand Down