Do not use getModelWithoutTraitShapes #547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gosar
force-pushed
the
no-getModelWithoutTraitShapes
branch
from
74124a5 to
c48e1d0
Compare
Merged
kstich
reviewed
May 24, 2022
| @@ -180,7 +177,7 @@ void execute() { | |||
| // Generate models that are connected to the service being generated. | |||
| LOGGER.fine("Walking shapes from " + service.getId() + " to find shapes to generate"); | |||
| // Walk the tree. | |||
| Collection<Shape> shapeSet = new Walker(nonTraits).walkShapes(service); | |||
| Collection<Shape> shapeSet = new Walker(model).walkShapes(service); | |||
|
|
|||
| Model prunedModel = Model.builder().addShapes(shapeSet).build(); | |||
There was a problem hiding this comment.
Is this necessary anymore? It was based upon the nonTraits model previously but that's gone, meaning places where this was used can just use model instead.
There was a problem hiding this comment.
Still needed. Otherwise, the TopologicalIndex will iterate and visit through more than shapeSet.
There was a problem hiding this comment.
Or I'll change it to use the model and check if shape is present in shapeSet before visiting.
The Walker does not traverse relationships create by traits anyways.
gosar
force-pushed
the
no-getModelWithoutTraitShapes
branch
from
c48e1d0 to
3f679c7
Compare
kstich
approved these changes
May 25, 2022
mtdowling
approved these changes
May 25, 2022
trivikr
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Walker does not traverse relationships create by traits anyways.
Ran
yarn generate-clients && yarn test:protocols && yarn generate-clients -s && yarn test:server-protocolsin aws-sdk-js-v3 with this change to confirm there is no change to clients. Though there is some rearrangement of code within a file in protocol tests. Here's the diff aws/aws-sdk-js-v3#3633By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.