Skip to content

fix: override typescript version for typedoc #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

eduardomourar
Copy link
Contributor

Issue #, if available: #560

Description of changes:

We will add the proper sub-dependencies overrides for both NPM and Yarn. This way we will not need to install with force resolution enabled.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eduardomourar eduardomourar requested a review from a team as a code owner June 7, 2022 19:59
@eduardomourar
Copy link
Contributor Author

Removed yarn resolutions property because it only gives a warning during installation and also resolution for peer dependencies is not yet supported (details here).

@trivikr trivikr merged commit ac8fb3f into smithy-lang:main Aug 4, 2022
@eduardomourar eduardomourar deleted the fix/typedoc-incompatible-dependency branch November 1, 2022 16:29
srchase pushed a commit to srchase/smithy-typescript that referenced this pull request Mar 17, 2023
srchase pushed a commit that referenced this pull request Mar 23, 2023
srchase pushed a commit that referenced this pull request Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants