Skip to content

Bump typescript to 4.7.3 #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Jun 16, 2022

Issue #, if available:
Internal JS-3363

Description of changes:
Bump typescript to 4.7.3

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr
Copy link
Contributor Author

trivikr commented Aug 4, 2022

Internal JS-3393 discusses blockers with updating typedoc to v0.22.x

@eduardomourar
Copy link
Contributor

We have been able to successfully migrate to typedoc v0.23.x (output example here). @trivikr, are you interested in us pushing upstream the changes to the whole documentation generation?

@trivikr
Copy link
Contributor Author

trivikr commented Nov 1, 2022

are you interested in us pushing upstream the changes to the whole documentation generation?

Yeah! That would be very helpful.

I've created a feature request at aws/aws-sdk-js-v3#4134
Can you post your findings there?

@trivikr
Copy link
Contributor Author

trivikr commented Jan 31, 2023

Closing as we're still blocked on bumping typedoc in aws/aws-sdk-js-v3#4134

Bumping TypeScript will be revisited when we either bump typedoc, or switch to a different solution for documentation.

@trivikr trivikr closed this Jan 31, 2023
@trivikr trivikr deleted the bump-typescript-4.7.3 branch January 31, 2023 18:50
@trivikr
Copy link
Contributor Author

trivikr commented Jan 31, 2023

If you're generating client using smithy-typescript, and not using typedoc or using a supported version of typedoc, you can always bump typescript version in the generated package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants