Remove usused code from ProtocolGenerator.GenerationContext #564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
approved these changes
Jun 20, 2022
Merged
gosar
added a commit
that referenced
this pull request
Jul 1, 2022
srchase
pushed a commit
to srchase/smithy-typescript
that referenced
this pull request
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 changes:
Remove unused integrations from ProtocolGenerator.GenerationContext
Didn't look into history, but is unused.
Remove unused ProtocolGenerator.GenerationContext.withSymbolProvider
This method was introduced in 6e8f090#diff-29f426bcf693083ef5343733b2f9813bd61186bf026c2dd81e6795824027ce0eR328 but become unnecessary with 91c6b12#diff-29f426bcf693083ef5343733b2f9813bd61186bf026c2dd81e6795824027ce0eR337.
Ran
yarn generate-clients && yarn test:protocols && yarn generate-clients -s && yarn test:server-protocolslocally and there is no change to generated clients.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.