Skip to content

Update to Smithy 1.23.x which supports IDL v2 #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 22, 2022

Conversation

gosar
Copy link
Contributor

@gosar gosar commented Aug 17, 2022

This upgrades from current 1.21 to 1.23.

Some tests had to be updated as @sensitive is not allowed on members now (from Smithy 1.22.0). Some tests were removed instead of updated because there is already another equivalent test. e.g., test-sensitive-member-pointing-to-list.smithy is just removed as there is already test-sensitive-list.

Since some prelude shapes like PrimitiveBoolean are deprecated now, they need to be excluded when adding @deprecated to member docs.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

gosar added 3 commits August 16, 2022 22:51
When adding `@deprecated` to member docs, exclude deprecated trait for prelude
shapes like `PrimitiveBoolean`.
@gosar gosar marked this pull request as ready for review August 19, 2022 19:27
@gosar gosar requested a review from a team as a code owner August 19, 2022 19:27
@trivikr trivikr merged commit 97cc342 into smithy-lang:main Aug 22, 2022
@gosar gosar deleted the bump-smithy branch August 24, 2022 19:01
srchase pushed a commit to srchase/smithy-typescript that referenced this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants