Update versions in README example #601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gosar
reviewed
Sep 29, 2022
README.md
Outdated
| operations: [Echo] | ||
| } | ||
|
|
||
| operation Echo { | ||
| input: EchoInput, | ||
| output: EchoOutput, | ||
| input: EchoInput |
There was a problem hiding this comment.
let's also update to use inline Input/output
There was a problem hiding this comment.
Updated. We could also extract message: String to a mixin, but I don't have a strong opinion on whether or not to do that
milesziemer
force-pushed
the
update-readme
branch
from
6687da2 to
e7b6ea1
Compare
gosar
approved these changes
Sep 29, 2022
kuhe
approved these changes
Nov 11, 2022
milesziemer
added a commit
to milesziemer/smithy-typescript
that referenced
this pull request
Dec 14, 2022
srchase
pushed a commit
to srchase/smithy-typescript
that referenced
this pull request
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.