loosen TS compiler config for noUnusedLocals #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srchase
approved these changes
Dec 20, 2019
srchase
pushed a commit
that referenced
this pull request
Mar 23, 2023
* Add buildspec.yml to orchestrate pull request testing * Ensure all packages have the correct types at their disposal * Prep SNS Message validator for upgrade to Jest 21 and ensure the CPU-intensive test has an adequate timeout * Ensure everything still compiles even with TypeScript 2.6's strict function types * Match any 32-char hex string for temp directories rather than mocking out crypto.randomBytes
srchase
pushed a commit
that referenced
this pull request
Jun 16, 2023
* Add buildspec.yml to orchestrate pull request testing * Ensure all packages have the correct types at their disposal * Prep SNS Message validator for upgrade to Jest 21 and ensure the CPU-intensive test has an adequate timeout * Ensure everything still compiles even with TypeScript 2.6's strict function types * Match any 32-char hex string for temp directories rather than mocking out crypto.randomBytes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some circumstances(e.g. endpoints.ts), it's very hard to infer which variable won't be used in the codegen, so we loose the ts config requirement to make the build pass.
Later on, we shoud introduce TS linter(like prettier) to remove ununsed variables in the codegen script.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.