Skip to content

chore: remove unsupported version deprecation warning #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Oct 31, 2022

Issue #, if available:
No longer needed, as we've ending support for Node.js 12.x in #623

Description of changes:
Removes call to unsupported version deprecation warning in runtimeConfig

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as ready for review October 31, 2022 22:06
@trivikr trivikr requested a review from a team as a code owner October 31, 2022 22:06
Copy link
Contributor

@kuhe kuhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider leaving the warning template in place in this template and modifying the runtime to no longer emit the warning.

This makes it easier to turn a warning back on later, a different warning.

@trivikr
Copy link
Contributor Author

trivikr commented Nov 1, 2022

I would consider leaving the warning template in place in this template and modifying the runtime to no longer emit the warning.

Yup, that's better. Posted a PR at aws/aws-sdk-js-v3#4127

@trivikr trivikr closed this Nov 1, 2022
@trivikr trivikr deleted the remove-unsupported-version-emit-warning branch November 1, 2022 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants