Use HttpResponse constructor in protocol tests #698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the TS protocol test stub to construct HttpResponse objects using the class constructor, instead of with object syntax. The constructor has optional parameters, so when updating the HttpResponse implementation we can continue to pass old properties. Without using the constructor, we have to change the HttpResponse interface and protocol test codegen simulataneously to avoid breaking changes.
kuhe
approved these changes
Mar 7, 2023
milesziemer
added a commit
to milesziemer/aws-sdk-js-v3
that referenced
this pull request
Mar 9, 2023
This commit contains changes from the codegen changes in smithy-lang/smithy-typescript#698. It updates protocol tests to construct the HttpResponse object, instead of using a regular object.
kuhe
pushed a commit
to aws/aws-sdk-js-v3
that referenced
this pull request
Mar 9, 2023
This commit contains changes from the codegen changes in smithy-lang/smithy-typescript#698. It updates protocol tests to construct the HttpResponse object, instead of using a regular object.
milesziemer
added a commit
to milesziemer/aws-sdk-js-v3
that referenced
this pull request
Mar 13, 2023
This change implements the core functionality of HttpResponse for SRA. New properties were added to the HttpResponse class, old properties and interfaces were deprecated. To maintain compatibility with old implementation, Proxy was added for headers property, and Object.defineProperties is used with getters/setters for other old properties. This change does not include updates to the SDK to use new functionality. Additional notes: * HttpResponse.isInstance was left unchanged to maintain compatibility. Previous implementation only checked for specific properties, so it would return true when passed the HttpResponse interface from types package. * smithy-lang/smithy-typescript#698 is a related change that ensures protocol tests are using HttpResponse constructor. Due to type changes in HttpResponse, this is required.
milesziemer
added a commit
to milesziemer/aws-sdk-js-v3
that referenced
this pull request
Mar 13, 2023
This change implements the core functionality of HttpResponse for SRA. New properties were added to the HttpResponse class, old properties and interfaces were deprecated. To maintain compatibility with old implementation, Proxy was added for headers property, and Object.defineProperties is used with getters/setters for other old properties. This change does not include updates to the SDK to use new functionality. Additional notes: * HttpResponse.isInstance was left unchanged to maintain compatibility. Previous implementation only checked for specific properties, so it would return true when passed the HttpResponse interface from types package. * smithy-lang/smithy-typescript#698 is a related change that ensures protocol tests are using HttpResponse constructor. Due to type changes in HttpResponse, this is required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Updates the TS protocol test stub to construct HttpResponse objects using the class constructor, instead of with object syntax. The constructor has optional parameters, so when updating the HttpResponse implementation we can continue to pass old properties. Without using the constructor, we have to change the HttpResponse interface and protocol test codegen simulataneously to avoid breaking changes.
Tested via js v3 sdk.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.