Add tests for convertRequest (NodeJS sSDK runtime). #711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pose
force-pushed
the
features/convert-request-tests
branch
from
e54dc85 to
28bfba0
Compare
kuhe
reviewed
Mar 7, 2023
kuhe
approved these changes
Mar 7, 2023
everett1992
reviewed
Mar 7, 2023
| resToEnd = res; | ||
| }); | ||
| // Create a temporary named pipe where to run the server and obtain a request | ||
| socketPath = path.join(await mkdtemp(path.join(os.tmpdir(), "named-pipe-for-test-")), "server"); |
There was a problem hiding this comment.
Why listen to a socket rather than a port? port 0 would bind to any free port.
There was a problem hiding this comment.
I'm not a huge fan of tests that depend on the TCP stack in general (probably since I have had clash with already used ports many times). It's also true that I can bind to the socket (as you describe) and it's probably going to be still quite fast. Do you think I'm losing performance or how realistic is the scenario under test?
everett1992
reviewed
Mar 7, 2023
| server?.close(); | ||
| }); | ||
|
|
||
| async function streamToString(stream: Readable) { |
There was a problem hiding this comment.
@aws-sdk/node-http-handler streamCollector?
There was a problem hiding this comment.
Thanks for the suggestion. I see the following caveats:
- It returns a
Uint8Arraywhich I still need to convert to String. - I'm introducing a new dependency
@aws-sdk/node-http-handleronly for this.
@kuhe what do you think?
everett1992
reviewed
Mar 7, 2023
srchase
approved these changes
Mar 10, 2023
srchase
pushed a commit
to srchase/smithy-typescript
that referenced
this pull request
Mar 17, 2023
Co-authored-by: Alberto Pose <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: Adding tests for
convertRequestmethod forserver-noderuntime.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.