fix: broken ChecksumConfiguration and ConditionalRecursiveTransformExact interface in TS < 4.4 #926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before TS 4.4, TS does not allow the index signature as union type. Consuming library with this interface will cause error: "TS1337: An index signature parameter type cannot be a union type. Consider using a mapped object type instead. [other: string | number]: any;". This issue was fixed in TS 4.4: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-4.html#symbol-and-template-string-pattern-index-signatures Fixing this issue so it won't break users with TSC < 4.4
|
Related issue: #876 |
stocaaro
approved these changes
Sep 12, 2023
kuhe
approved these changes
Sep 12, 2023
The referred type `ConditionalRecursiveTransformExact<T, FromType, ToType>` uses conditional generic type that is only supported in TS>=4.1. However the typesVersions directs consumers' TSC 4.0 to the types with this definition, hence consumers will see following error: error TS2315: Type 'ConditionalRecursiveTransformExact' is not generic. Changing the typesVersions directive resolves the issue.
srchase
approved these changes
Sep 12, 2023
syall
approved these changes
Sep 12, 2023
AllanZhengYP
changed the title
srchase
approved these changes
Sep 12, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following 2 issues:
ConditionalRecursiveTransformExact<T, FromType, ToType>usesconditional generic type that is only supported in TS>=4.1. However the typesVersions
directs consumers' TSC 4.0 to the types with this definition, hence consumers will see
following error:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.