Skip to content

Check method before calling external middlewareStack instance #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Sep 21, 2023

in case of multiple versions of middlewareStack existing, external versions may be older and not have the latest method identifyOnResolve.

This should be fixed by installing a consistent and recent version of SDK clients, or specifically @smithy/middleware-stack, but if needed, this check can be put in place.

@kuhe kuhe requested review from a team as code owners September 21, 2023 02:09
@kuhe kuhe force-pushed the fix/middlewareStack branch from 4295fc9 to 7e945f3 Compare September 21, 2023 02:14
@kuhe kuhe force-pushed the fix/middlewareStack branch from 7e945f3 to 0d243ca Compare September 21, 2023 02:15
@trivikr trivikr changed the title check method before calling external middlewareStack instance Check method before calling external middlewareStack instance Sep 21, 2023
@trivikr trivikr merged commit 20fc148 into smithy-lang:main Sep 21, 2023
@kuhe kuhe deleted the fix/middlewareStack branch September 21, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants