Change client_impl::send_impl() not to delay ping #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
client_impl::close_impl() only gets called when the user is closing the
connection ("End by user"), when there is a handshake error, when the
server sends a frame_close packet ("End by server"), or when there is a
pong timeout.
Before, in the case where send_impl() would continously get called with
an interval less than client_impl::m_ping_interval, a disconnect due to
network problems would never be detected because the ping would keep
getting delayed, thus never allowing the pong timeout to happen. This
fixes that by not delaying pings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where a disconnect can go undetected.
In the case where
client_impl::send_impl()continuously gets called with an interval less thanclient_impl::m_ping_interval, a disconnect due to network connectivity problems is never detected because the ping keeps getting delayed bysend_impl(), thus not allowing a pong timeout to happen, which results inclient_impl::close_impl()never being called.