Add options to choose between static and dynamic libraries #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-raman
force-pushed
the
master
branch
from
6293f00 to
dc045ba
Compare
melode11
added a commit
that referenced
this pull request
Sep 10, 2015
Add options to choose between static and dynamic libraries
|
Great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, socket.io-client-cpp is all static but we could want to choose between static and dynamic.
Furthermore, in some distribution, boost comes only in dynamic.
I propose then to make an option of Boost_USE_STATIC_LIBS (ON by default) and of BUILD_SHARED_LIBS (OFF by default)
By default the behavior will stay the same but we can change with
cmake ../ -DBoost_USE_STATIC_LIBS=OFF -DBUILD_SHARED_LIBS=ON