Skip to content

Let's be more specific w.r.t. Async::HTTP::Server#run. #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2024
Merged

Let's be more specific w.r.t. Async::HTTP::Server#run. #158

merged 1 commit into from
Apr 30, 2024

Conversation

ioquatix
Copy link
Member

@ioquatix ioquatix commented Apr 30, 2024 •
edited
Loading

::IO::Endpoint returns bare fibers, and we need to wait on them. Change Async::Server#run to return a single task which can be waited on.

Types of Changes

  • Bug fix.
  • Breaking change.

Contribution

@ioquatix ioquatix force-pushed the async-server-run-task branch from 376259c to 3012e42 Compare April 30, 2024 01:12
@ioquatix ioquatix merged commit c12f462 into main Apr 30, 2024
18 of 36 checks passed
@ioquatix ioquatix deleted the async-server-run-task branch April 30, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ioquatix