Correctly pass @options to Async::Redis::Client instances created by Async::Redis::ClusterClient.
#60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
approved these changes
Feb 28, 2025
ioquatix
changed the title
@options to Async::Redis::Client instances created by Async::Redis::ClusterClient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change to allow
Async::Redis::ClusterClientto accept an optional argument of options that are passed toAsync::Pool::Controller.wrap. The goal of this change is to have parity withAsync::Redis::Client.Tests are passing but I didn't create a new test to validate the options are being passed in. I took a quick look at it but neither the
optionsor@poolare accessible so without a few more changes (or mocking), I couldn't quite get there.