Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

gitserver: Move search observability #61859

Merged
merged 1 commit into from
Apr 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions cmd/gitserver/internal/search.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ import (
"sync/atomic"
"time"

"github.com/prometheus/client_golang/prometheus"
"github.com/prometheus/client_golang/prometheus/promauto"
"github.com/sourcegraph/log"
"go.opentelemetry.io/otel/attribute"

Expand All @@ -21,6 +23,23 @@ import (
"github.com/sourcegraph/sourcegraph/internal/trace"
)

var (
searchRunning = promauto.NewGauge(prometheus.GaugeOpts{
Name: "src_gitserver_search_running",
Help: "number of gitserver.Search running concurrently.",
})
searchDuration = promauto.NewHistogramVec(prometheus.HistogramOpts{
Name: "src_gitserver_search_duration_seconds",
Help: "gitserver.Search duration in seconds.",
Buckets: []float64{0.01, 0.05, 0.1, 0.2, 0.5, 1, 2, 5, 10, 30},
}, []string{"error"})
searchLatency = promauto.NewHistogram(prometheus.HistogramOpts{
Name: "src_gitserver_search_latency_seconds",
Help: "gitserver.Search latency (time until first result is sent) in seconds.",
Buckets: []float64{0.01, 0.05, 0.1, 0.2, 0.5, 1, 2, 5, 10, 30},
})
)

func searchWithObservability(ctx context.Context, logger log.Logger, repoDir common.GitDir, tr trace.Trace, args *protocol.SearchRequest, onMatch func(*protocol.CommitMatch) error) (limitHit bool, err error) {
searchStart := time.Now()

Expand Down
15 changes: 0 additions & 15 deletions cmd/gitserver/internal/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -721,21 +721,6 @@ func scanCRLF(data []byte, atEOF bool) (advance int, token []byte, err error) {
}

var (
searchRunning = promauto.NewGauge(prometheus.GaugeOpts{
Name: "src_gitserver_search_running",
Help: "number of gitserver.Search running concurrently.",
})
searchDuration = promauto.NewHistogramVec(prometheus.HistogramOpts{
Name: "src_gitserver_search_duration_seconds",
Help: "gitserver.Search duration in seconds.",
Buckets: []float64{0.01, 0.05, 0.1, 0.2, 0.5, 1, 2, 5, 10, 30},
}, []string{"error"})
searchLatency = promauto.NewHistogram(prometheus.HistogramOpts{
Name: "src_gitserver_search_latency_seconds",
Help: "gitserver.Search latency (time until first result is sent) in seconds.",
Buckets: []float64{0.01, 0.05, 0.1, 0.2, 0.5, 1, 2, 5, 10, 30},
})

pendingClones = promauto.NewGauge(prometheus.GaugeOpts{
Name: "src_gitserver_clone_queue",
Help: "number of repos waiting to be cloned.",
Expand Down