Travis-CI tidy and expand build matrix for GCC 7 #376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Partially reverts e293e5d - Correctly handles Mac OS homebrew install of gcc@6 - See also #65 (comment)
- Expand build matrix over GCC 6 & 7 instead of BUILD_TYPE, skipping 7 on Ubuntu due to not being in Travis-CI white-list (but only use 6 for install script) - Run all CMake build types in each GCC (6 or 7) instance but not install script instances - Make some style changes: always brace variables and use the new test command (`[[ ... ]]` instead of '[ ... ]`) and use `type -P` instead of `which`, and compress ifs with && operators inside double brackets
- pip install yamllint - gem install yaml-lint
Codecov Report
@@ Coverage Diff @@
## master #376 +/- ##
=========================================
- Coverage 46.22% 39.3% -6.92%
=========================================
Files 3 3
Lines 1045 1707 +662
Branches 201 294 +93
=========================================
+ Hits 483 671 +188
- Misses 483 937 +454
- Partials 79 99 +20 |
|
I guess coverage goes down because more conditional code is included, despite more tests being added. I think this makes sense in the coverage diff because we've hit an additional 188 lines by enabling GCC 7 but have missed and additional 454 for a net decrease. |
Cleaned with: - shellcheck - style.pl - shfmt -i 2
- Marks a build as failed/errored as soon as a job has failed/errored (that isn't an allowed failure) - Marks a build as successful when the only remaining jobs are allowed failures and all others have returned successfully
- Previously just having OPENCOARRAYS_DEVELOPER *set* would enable dev tests. Now must be set to something that CMake evaluates to true in `if ( <string> )` see `if()` documentation for help
- Add back `set -o errexit` so that Travis-CI will detect errors
- Due to `[[ -v var ]]`, probably not in bash3? Or only supported by old test command - Error introduced by me, @zbeekman a few commits ago
|
Assuming I fixed the install script test issue, this PR looks good to me
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
.travis.ymlwas simplified, cleaned and tidied, and all CMake build configurations are tested per build matrix entry, excluding InstallScript builds. GCC 7 still hasn't hit Precise toolchain-r-test so GCC 7 is only enabled on Mac OS, for now.Rationale for changes
GCC 7 has been officially released, and includes important bug fixes, and new features for OpenCoarrays. In addition, our reported test coverage will increase because tests specialized to new features and GCC 7 will now be aggregated with Codecov.io along with GCC 6 tests.
Additional info and certifications
This pull request (PR) is a:
I certify that:
WIP:to thebeginning of the PR title
DO NOT MERGE:to the beginning of the titleissue-<#>where<#>is replaced by the issue that this PRis addressing
touches
touches
changes
ctest) and all tests passset of changes
imperative verb, and is no longer than 50 characters
summarizing your commit
include additional paragraphs, bulleted lists, etc.
commit resolves an open issue.
clicking the "details" link to the right of the
licence/clacheck and following the directions on the CLA assistant webpage
For contributors and SI team members with code review priviledges
pullapprove comment or Github code review so that someone
else has the chance to review my proposed changes