Skip to content

add missing space for cafrun -w option #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

LaHaine
Copy link
Contributor

@LaHaine LaHaine commented May 11, 2017

This calls mpiexec -v

Avg response time coverage on master
Issue Stats Codecov branch

Summary of changes

This is a trivial change that fixes the cafrun wrapper script if called with -w or --wraps option.

Summarize what you changed
I have added one space

Rationale for changes

cafrun -w produced this error:
cafrun: line 80: /opt/ohpc/pub/mpi/openmpi-gnu/1.10.6/bin/mpiexec-v: No such file or directory

Additional info and certifications

This pull request (PR) is a:

  • Bug fix
  • Feature addition
  • Other, Please describe:

I certify that:

  • I have reviewed the contributing guidelines
  • If this PR is a work in progress I have added WIP: to the
    beginning of the PR title
  • If this PR is problematic for any reason, I have added
    DO NOT MERGE: to the beginning of the title
  • The branch name and title of this PR contains the text
    issue-<#> where <#> is replaced by the issue that this PR
    is addressing
  • I have deleted trailing white space on any lines that this PR
    touches
  • I have used spaces for indentation on any lines that this PR
    touches
  • I have included some comments to explain non-obvious code
    changes
  • I have run the tests localy (ctest) and all tests pass
  • Each commit is a logically atomic, self-consistent, cohesive
    set of changes
  • The commit message should follow these guidelines:
    • First line is directive phrase, starting with a capitalized
      imperative verb, and is no longer than 50 characters
      summarizing your commit
    • Next line, if necessary is blank
    • Following lines are all wrapped at 72 characters and can
      include additional paragraphs, bulleted lists, etc.
    • Use Github keywords where appropriate, to indicate the
      commit resolves an open issue.
  • I have signed Contributor License Agreement (CLA) by
    clicking the "details" link to the right of the licence/cla
    check and following the directions on the CLA assistant webpage
  • I have ensured that the test coverage hasn't gone down and added new unit tests to cover an new code added to the library

For contributors and SI team members with code review priviledges

@codecov
Copy link

codecov bot commented May 11, 2017

Codecov Report

Merging #383 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #383   +/-   ##
======================================
  Coverage    39.3%   39.3%           
======================================
  Files           3       3           
  Lines        1707    1707           
  Branches      294     294           
======================================
  Hits          671     671           
  Misses        937     937           
  Partials       99      99

@zbeekman
Copy link
Collaborator

@LaHaine Thanks for catching this. I'm actually in the process of refactoring the caf and cafrun scripts, so I'll probably close this PR and incorporate your changes (or an alternate version) manually.

Thanks!

@zbeekman
Copy link
Collaborator

Fixed on one of my branches, merging upstream to master soonish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants