Skip to content

Fix by replacing error_stop with terminate_internal. #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2017

Conversation

vehre
Copy link
Collaborator

@vehre vehre commented Jun 2, 2017

Avg response time coverage on master
Issue Stats Codecov branch

Summary of changes

Replaced calls to non-existent error_stop function (don't mix this up with PREFIX (error_stop)) with the internal_terminate.

Rationale for changes

Allow compiling again.

Additional info and certifications

This pull request (PR) is a:

  • Bug fix
  • Feature addition
  • Other, Please describe:

I certify that

  • I have reviewed the contributing guidelines and followed the
    policies on:
    - Pull request (PR) naming to indicate work in progress (WIP),
    and to attach the PR to the appropriate bug report, or feature
    request issue
    - White space (no trailing white space or white space errors may
    be introduced)
    - Commenting code where it is non-obvious and non-trivial
    - Running tests locally, to ensure all of them pass
    - Maintaining or increasing test coverage
    - Logically atomic, self consistent and coherent commits
    - Commit message content
    - Waiting 24 hours before self-approving the pull request to
    give another OpenCoarrays developer a chance to review my
    proposed code

@codecov
Copy link

codecov bot commented Jun 2, 2017

Codecov Report

Merging #398 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #398   +/-   ##
=======================================
  Coverage   38.02%   38.02%           
=======================================
  Files           3        3           
  Lines        1996     1996           
  Branches      330      330           
=======================================
  Hits          759      759           
  Misses       1127     1127           
  Partials      110      110

@zbeekman
Copy link
Collaborator

zbeekman commented Jun 2, 2017

Hi @vehre, Is this connected to an issue? Or is it a pre-emptive fix?

Either way,

LGTM

Approved with PullApprove

Copy link
Collaborator

@zbeekman zbeekman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is connected to an open issue, can you please include that here? Otherwise this looks great.

@zbeekman zbeekman merged commit 232d234 into master Jun 2, 2017
@zbeekman zbeekman deleted the fix-error-stop-calls branch June 2, 2017 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants