Safer prereq urls #406
Merged
Safer prereq urls #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Help prevent MITM attacks - Ensure secure best practices - Use HTTPS urls wherever possible/available
- Whitespace fix - Pass/Fail condition
|
Also small whitespace cleanup to test added by Andre, and small fix for pass/fail condition of that test in top level CMakeLists.txt, and deleted robodoc stuff since we're (going to be) using FORD |
Codecov Report
@@ Coverage Diff @@
## master #406 +/- ##
=======================================
Coverage 38.02% 38.02%
=======================================
Files 3 3
Lines 1996 1996
Branches 330 330
=======================================
Hits 759 759
Misses 1127 1127
Partials 110 110 |
|
LGTM
|
|
LGTM
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Use HTTPS protocol for getting prerequisites, to prevent MITM attacks, and mitigate possibility of installing malware
Rationale for changes
http is not a secure protocol for downloading and installing software
Additional info and certifications
This pull request (PR) is a:
I certify that
policies on:
- Pull request (PR) naming to indicate work in progress (WIP),
and to attach the PR to the appropriate bug report, or feature
request issue
- White space (no trailing white space or white space errors may
be introduced)
- Commenting code where it is non-obvious and non-trivial
- Running tests locally, to ensure all of them pass
- Maintaining or increasing test coverage
- Logically atomic, self consistent and coherent commits
- Commit message content
- Waiting 24 hours before self-approving the pull request to
give another OpenCoarrays developer a chance to review my
proposed code