Skip to content

Add install.sh/build.sh option --disable-bootstrap #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2017

Conversation

rouson
Copy link
Member

@rouson rouson commented Jul 11, 2017

Avg response time coverage on master
Issue Stats Codecov branch

Summary of changes

The install.sh and build.sh now recognize the -z or equivalently --disable-bootstrap options and add or omit the corresponding arguments during make of GCC.

Rationale for changes

When building with a recent GCC, this can speed up the build process.

Additional info and certifications

This pull request (PR) is a:

  • Bug fix
  • Feature addition
  • Other, Please describe:

I certify that

  • I have reviewed the contributing guidelines and followed the
    policies on:
    - Pull request (PR) naming to indicate work in progress (WIP),
    and to attach the PR to the appropriate bug report, or feature
    request issue
    - White space (no trailing white space or white space errors may
    be introduced)
    - Commenting code where it is non-obvious and non-trivial
    - Running tests locally, to ensure all of them pass
    - Maintaining or increasing test coverage
    - Logically atomic, self consistent and coherent commits
    - Commit message content
    - Waiting 24 hours before self-approving the pull request to
    give another OpenCoarrays developer a chance to review my
    proposed code

@rouson rouson requested a review from zbeekman July 11, 2017 21:51
@zbeekman
Copy link
Collaborator

zbeekman commented Jul 11, 2017

LGTM

Approved with PullApprove

Copy link
Collaborator

@zbeekman zbeekman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@codecov
Copy link

codecov bot commented Jul 11, 2017

Codecov Report

Merging #410 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #410   +/-   ##
=======================================
  Coverage   38.02%   38.02%           
=======================================
  Files           3        3           
  Lines        1996     1996           
  Branches      330      330           
=======================================
  Hits          759      759           
  Misses       1127     1127           
  Partials      110      110

@zbeekman
Copy link
Collaborator

zbeekman commented Jul 11, 2017

still
💯

Apparently that's not a regex... I should add it.

👍

Approved with PullApprove

@rouson
Copy link
Member Author

rouson commented Jul 11, 2017

@zbeekman what does the red "100" mean?

@zbeekman
Copy link
Collaborator

zbeekman commented Jul 11, 2017

what does the red "100" mean?

It's like when you were in grade school and your teacher used red pen for everything (the merits of this practice are beyond the scope of this comment) but an underlined 100 usually meant a perfect score on the test/assignment/homework/paper/etc

EDIT: i.e., "Great job!!!!!"

EDIT2: just to clarify, the pullaprove regex are defined here: https://pullapprove.com/sourceryinstitute/
and I have added :100: as an acceptable "approve" regex

@zbeekman zbeekman merged commit 8977be3 into master Jul 12, 2017
@zbeekman zbeekman deleted the add-disable-bootstrap branch July 12, 2017 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants