Return HttpResult<Listening> from serve() #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrgn
changed the title
|
I also added an integration test that tests connectivity to the server. Anyone up for a review? Finally tests again :) |
|
@coredump-ch/spaceapi bump :) |
|
The failing test is due to rust-lang/cargo#886. I'm investigating. |
|
The strange thing is, I cannot reproduce this locally :/ |
|
Oops, I was on the wrong branch. Could reproduce and found the issue. We depended on an old version of Hyper. Should be fixed now. |
This can be used to stop the server again, by calling the `close()` method on the `Listening` instance. Because Iron doesn't re-publish the `Listening` type, we need to add Hyper as a dependency. See iron/iron#406. This change allows us to add integration tests that test the server output.
It starts a new server instance and verifies that a TCP connection to it works.
| let host = self.host; | ||
| let port = self.port; | ||
|
|
||
| let router = self.route(); | ||
|
|
||
| println!("Starting HTTP server on http://{}:{}...", host, port); | ||
| Iron::new(router).http((host, port)).unwrap(); | ||
| Iron::new(router).http((host, port)) |
|
Good to merge 👍 |
dbrgn
added a commit
that referenced
this pull request
Dec 7, 2015
Return HttpResult<Listening> from serve()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be used to stop the server again, by calling the
close()method on the
Listeninginstance.Because Iron doesn't re-publish the
Listeningtype, we need to addHyper as a dependency. See iron/iron#406.
This change allows us to add integration tests that test the server
output.