Fix for fence post error in Display Customer Character function #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a bug (Fence Post error) in the Display Customer character command that allowed the user to request a ninth character when only 8 are allowed. The upper limit in the if statement was off by one. The allowable range should be 35 to 42, inclusive, not 35 to 43.
Fixed a fence post error in the Display Custom Character function
This allows the user to print a pipe control character to the display by escaping the control character as a double pipe
Add logic to print pipe if second control chracter is read
Merged
|
Looks good! Duplicate of #7. Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the if statement in file OpenLCD.ino, line 266 to be 35 to 42 inclusive. This removes the extraneous display customer character function for a ninth (non-existent) character.
Closes #5