Add the WebServer test sketch #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nseidle
reviewed
May 12, 2022
| @@ -0,0 +1,162 @@ | |||
| /* | |||
| Web server test program | |||
There was a problem hiding this comment.
Additional comments here please. What's this do? Why does it exist?
There was a problem hiding this comment.
I would copy/paste most of your original PR message.
nseidle
reviewed
May 12, 2022
| int wifiConnected; | ||
|
|
||
| //-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- | ||
| int mountSdCard(void) { |
There was a problem hiding this comment.
This is purely stylistic, but sketches have setup(), then loop(), then any supporting functions. Users (I constantly think about the students I taught) want to know what the thing does, and can get lost scrolling though lots of top functions just to get to setup/loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New test sketch to serve the files on the SD card.
Using the serial connection, enter the WiFi network name (SSID) and password. Once complete, the system will display the IP address if it is able to connect to the specified WiFi network. Using a browser on another system, connect to the IP address that the ESP32 system displayed. If the SD card socket is empty, an error message will be displayed on the browser. Just insert the SD card and refresh the webpage.
If an SD card is in the socket, a link should show up on the browser describing the SD card. If the SD card is not properly formatted, and error message will be displayed on the browser. Otherwise, clicking on this link will display the files on the SD card. Clicking on one of the file links downloads that file from the ESP32 system to the computer running the browser.