Rover states #112
Merged
Rover states #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Lee - thanks for these. PR 114, 113, and 112 look very similar. I see you are adding states to the State.ino (great!) but you've also got the same mod to SD_FileListing.ino inside your test sketch, three times over. Is that intentional? Looks like an error. It would make it easier on me if the changes were only to states.ino.
|
|
Hi Nathan,
Sorry, I am fighting the learning curve with GitHub. I noticed that
yesterday and tried to layer PR 114 just on top of v1.12 but it was
rejected by GitHub. I don't fully understand. I will try to rework PRs
112, 113 and 114 to be independent of SD_FileListing.ino.
|
|
Perfect! Thanks for removing the extra files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the rover state diagram to the code.