Change semaphore name from xFATSemaphore to sdCardSemaphore #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The semaphore is protecting access to the SPI controller used to access the SD card. Any operations to the SD card need to be protected by this semaphore.
|
Very good. Thanks. I'm a little concerned that you've moved the debug statements to full prints (all users will see them) but they are important and rare enough I suspect it will be a fair tradeoff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The semaphore is protecting access to the SPI controller used to access
the SD card. Any operations to the SD card need to be protected by this
semaphore.