Skip to content

Display code update #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jun 1, 2022
Merged

Display code update #148

merged 14 commits into from
Jun 1, 2022

Conversation

LeeLeahy2
Copy link
Contributor

This change includes:

  • Moves all display code into Display.ino
  • Moves all display variables into Display.ino
  • Eliminates duplicate code
  • Common code to handle icon blinking
  • Use bit vector to determine which icons to display

@nseidle
Copy link
Member

nseidle commented Jun 1, 2022

This is a big contribution - Thanks @LeeLeahy2! Works well on the Facet/Express/Surveyor.

@nseidle nseidle merged commit 5971483 into sparkfun:release_candidate Jun 1, 2022
@LeeLeahy2 LeeLeahy2 deleted the display branch June 3, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeeLeahy2 @nseidle