split up default writer #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

freekmurze merged 2 commits into spatie:master from lsmith77:refactor-default-writer

Jan 4, 2021

Contributor

lsmith77 commented Jan 2, 2021 •

edited

Loading

see #38

Contributor Author

lsmith77 commented Jan 2, 2021

hmm not so experienced yet with GH, any idea why the tests failed?

Member

freekmurze commented Jan 4, 2021

There seems to be an undefined variables somewhere: https://github.com/spatie/laravel-http-logger/pull/39/checks?check_run_id=1637118973#step:5:39


          split up default writer

38ccfd1

lsmith77 force-pushed the refactor-default-writer branch from f197759 to 38ccfd1 Compare

January 4, 2021 07:59

Contributor Author

lsmith77 commented Jan 4, 2021

ok looks better now. sorry about that.


          Update DefaultLogWriter.php

bcbd622

freekmurze merged commit c45ab64 into spatie:master

Member

freekmurze commented Jan 4, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet