Skip to content

Add option to sanitize sensitive headers #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 24, 2023

Conversation

stfndamjanovic
Copy link
Contributor

This PR adds the possibility to sanitize some headers that shouldn't be stored in logs, especially if you are using some third-party logging driver. For example, most likely we don't want to send jwt tokens from the Authorization header, or some IP addresses, etc. Because of that, I added one more configuration field to define headers that should be sanitized before sending.

I didn't want to add some headers in the configuration by default, because maybe it would be backward incompatible since it would be a change of existing behavior.

Let me know if you have any questions or suggestions. 😊

@freekmurze
Copy link
Member

Thanks! Could you uptime the readme as well?

@stfndamjanovic
Copy link
Contributor Author

Of course. It's done. Please check if everything is clear enough.

@stfndamjanovic
Copy link
Contributor Author

@freekmurze is there anything that I need to change?

@freekmurze freekmurze merged commit 31a02ff into spatie:main Jul 24, 2023
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants